Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppCleaner: Fix inconsistencies when using ACS and Shizuku #1373

Merged
merged 5 commits into from
Aug 21, 2024
Merged

AppCleaner: Fix inconsistencies when using ACS and Shizuku #1373

merged 5 commits into from
Aug 21, 2024

Commits on Aug 21, 2024

  1. AppCleaner: Fix size calculation for apps with mixed inaccessible caches 

    "Inaccessible caches" already includes the public default cache size.
    @d4rken
    d4rken committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    dcc3213 View commit details
    Browse the repository at this point in the history

  2. Clean up code, previous identifier approach was confusing and prone t… 

    …o errors
    @d4rken
    d4rken committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b6575ae View commit details
    Browse the repository at this point in the history

  3. When deleting inaccessible caches, also remove the default public cac… 

    …he matches as they were deleted too.
    @d4rken
    d4rken committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fe08144 View commit details
    Browse the repository at this point in the history

  4. Improve naming for InaccessibleCache sizes

    @d4rken
    d4rken committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    fcb54fc View commit details
    Browse the repository at this point in the history

  5. When running ACS and Shizuku in combination we have an overlap betwee… 

    …n `InaccessibleCache` (contains public and private default caches) and `DefaultCachesPublicFilter`.

Both affect each other and this needs to be taken into account when deleting either, i.e. remove entries and recalculate sizes.
    @d4rken
    d4rken committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f3f2347 View commit details
    Browse the repository at this point in the history