Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made busy-indicator work within modules #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmoisse
Copy link

@mmoisse mmoisse commented Feb 27, 2019

Made busy-indicator work within modules, requires git version of shinyjs daattali/shinyjs@8627e85

Made busy-indicator work within modules, requires git version of shinyjs daattali/shinyjs@8627e85
@daattali
Copy link
Owner

Was wrapping each input in its namespace the only thing required to do?

@mmoisse
Copy link
Author

mmoisse commented Mar 9, 2019

Apart from using the latest shiny js which fix a bug when id is NULL, it is the only thing I changed

@daattali
Copy link
Owner

In that case I would prefer to mention in the README that the input names need to be wrapped in the namespace function if used in a module, but the vast majority of people don't use modules and I think this code will add extra complexity/confusion. If I'm not mistaken, there's also a stackoverflow question about this (maybe you asked it?) so if the answer is on stackoverflow I think that's good enough.

I do appreciate you taking the time to make the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants