-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display learning module level regardless of the challenge level #1295
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughWalkthroughThe changes involve modifications to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add Documentation and Community
|
✅ Deploy Preview for staging-dacade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- src/components/cards/LearningModule.tsx (2 hunks)
- src/components/sections/courses/_partials/Duration.tsx (1 hunks)
Additional comments not posted (3)
src/components/sections/courses/_partials/Duration.tsx (1)
30-30
: Verify the impact of the change induration
variable handling.The
duration
variable is now set to an empty string when thevalue
prop is falsy. Ensure that this change does not negatively impact any downstream logic or rendering that relies on theduration
variable, particularly if it expects a number versus a string.src/components/cards/LearningModule.tsx (2)
27-29
: Verify the impact of the change inlevel
determination.The
level
now exclusively relies ondata?.level
. Ensure that this change does not negatively impact the rendering behavior, particularly in scenarios where thedata
object might not be available.
41-41
: Verify the impact of the change in the condition for rendering theTag
component.The condition for rendering the
Tag
component has been modified to check fordata?.level
instead ofchallenge?.level
. Ensure that this change does not negatively impact the rendering behavior, particularly in scenarios where thedata
object might not be available.
Submit a pull request
Replace any ":question:" below with information about your pull request.
Pull Request Details
This PR aims at displaying the learning module level on both; The learning materials and the Challenge pages:question:
Issues Fixed
Other Relevant Information