Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import missing packages and clean up unreference files #128

Conversation

earrmouth
Copy link
Contributor

This PR Imported missing packages necessary for setting fontFamily to monospace

Background

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@piyoki piyoki added the fix label Jun 30, 2023
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution, it truly helps a lot

@kunish kunish merged commit 798977c into daeuniverse:try-fixing-caret-position Jun 30, 2023
15 checks passed
kunish added a commit that referenced this pull request Jul 1, 2023
* fix: disable fontLigatures to try fixing caret misplacement

* fix: set fontFamily to monospace to try fixing caret misplacement

* fix: import missing packages and clean up unreference files (#128)

---------

Co-authored-by: dae-bot[bot] <136105375+dae-bot[bot]@users.noreply.github.com>
Co-authored-by: earrmouth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants