-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Summary & Motivation Ran into some Jest warnings in Plus that point at React version mismatches. It's already on 18.3.1, so let's bump these too. ## How I Tested These Changes `yarn jest` in Plus app, no more warnings. ## Changelog NOCHANGELOG
- Loading branch information
Showing
9 changed files
with
188 additions
and
258 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
js_modules/dagster-ui/packages/ui-components/src/components/DateRangePickerWrapper.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
119 changes: 1 addition & 118 deletions
119
js_modules/dagster-ui/packages/ui-core/src/ui/BaseFilters/DateRangePickerWrapper.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,121 +1,4 @@ | ||
| import {Colors} from '@dagster-io/ui-components'; | ||
| import * as React from 'react'; | ||
| import {DateRangePicker} from 'react-dates'; | ||
| import styled from 'styled-components'; | ||
|
|
||
| import 'react-dates/initialize'; | ||
| import 'react-dates/lib/css/_datepicker.css'; | ||
|
|
||
| export const DateRangePickerWrapper = (props: React.ComponentProps<typeof DateRangePicker>) => { | ||
| return ( | ||
| <DatePickerContainer> | ||
| <DateRangePicker {...props} /> | ||
| </DatePickerContainer> | ||
| ); | ||
| }; | ||
|
|
||
| const DatePickerContainer = styled.div` | ||
| .DateRangePickerInput { | ||
| background-color: ${Colors.backgroundDefault()}; | ||
| } | ||
| .DateRangePickerInput__withBorder { | ||
| border-color: ${Colors.borderDefault()}; | ||
| } | ||
| .DateInput { | ||
| background-color: ${Colors.backgroundDefault()}; | ||
| } | ||
| .DateRangePickerInput_arrow_svg { | ||
| fill: ${Colors.textLighter()}; | ||
| } | ||
| .DateInput_input { | ||
| background-color: ${Colors.backgroundDefault()}; | ||
| color: ${Colors.textDefault()}; | ||
| } | ||
| .DateInput_input::placeholder { | ||
| color: ${Colors.textLight()}; | ||
| } | ||
| .DateInput_input__focused { | ||
| border-color: ${Colors.accentBlue()}; | ||
| outline: none; | ||
| } | ||
| .DateInput_fangShape { | ||
| fill: ${Colors.backgroundLight()}; | ||
| } | ||
| .DateInput_fangStroke { | ||
| stroke: ${Colors.keylineDefault()}; | ||
| } | ||
| .DateRangePicker_picker { | ||
| background-color: ${Colors.backgroundLight()}; | ||
| color: ${Colors.textDefault()}; | ||
| } | ||
| .DayPicker { | ||
| background-color: ${Colors.backgroundLight()}; | ||
| color: ${Colors.textDefault()}; | ||
| } | ||
| .DayPickerNavigation_button__default { | ||
| background-color: ${Colors.backgroundLight()}; | ||
| border-color: ${Colors.borderDefault()}; | ||
| :hover { | ||
| border-color: ${Colors.borderHover()}; | ||
| } | ||
| } | ||
| .DayPickerNavigation_svg__horizontal { | ||
| fill: ${Colors.textLight()}; | ||
| } | ||
| .DayPicker_weekHeader { | ||
| color: ${Colors.textLighter()}; | ||
| } | ||
| .CalendarMonthGrid, | ||
| .CalendarMonth { | ||
| background-color: ${Colors.backgroundLight()}; | ||
| color: ${Colors.textDefault()}; | ||
| } | ||
| .CalendarMonth_caption { | ||
| color: ${Colors.textLight()}; | ||
| } | ||
| .CalendarDay__default { | ||
| background-color: ${Colors.backgroundLight()}; | ||
| border-color: ${Colors.keylineDefault()}; | ||
| color: ${Colors.textLight()}; | ||
| :hover { | ||
| background-color: ${Colors.backgroundBlue()}; | ||
| border-color: ${Colors.keylineDefault()}; | ||
| } | ||
| } | ||
| .CalendarDay__selected { | ||
| background-color: ${Colors.backgroundBlueHover()}; | ||
| :active, | ||
| :hover { | ||
| border-color: ${Colors.keylineDefault()}; | ||
| } | ||
| } | ||
| .CalendarDay__hovered_span, | ||
| .CalendarDay__hovered_span_3 { | ||
| background-color: ${Colors.backgroundBlue()}; | ||
| border-color: ${Colors.keylineDefault()}; | ||
| } | ||
| `; | ||
| import {DateRangePickerWrapper} from '@dagster-io/ui-components'; | ||
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default DateRangePickerWrapper; |
Oops, something went wrong.
c1dae95There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-core-storybook ready!
✅ Preview
https://dagit-core-storybook-4eum0eoe3-elementl.vercel.app
Built with commit c1dae95.
This pull request is being automatically deployed with vercel-action
c1dae95There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy preview for dagit-storybook ready!
✅ Preview
https://dagit-storybook-e0srdevn6-elementl.vercel.app
Built with commit c1dae95.
This pull request is being automatically deployed with vercel-action