Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-tableau] Use tableauserverclient #24826

Merged

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Sep 26, 2024

Summary & Motivation

Updates dagster-tableau to use tableauserverclient instead of requests.

Our first implementation leveraged requests, as suggested in their Tableau REST API documentation website and samples, see here and here.

Tableau provides a python client for their APIs, which is not mentioned on their REST API documentation website, but can be found here, docs here.

The library seems to be maintained only a few times a year, but the main reasons for using tableauserverclient instead of requests are:

  • all their endpoints are already implemented.
    • Some of their endpoints support JSON, some other only XML. Using the library makes it easier to handle the edge cases.
  • Using requests and following their documentation here and here, I wasn't able query their update workbook now endpoint without receiving a HTTP error 400 without much information to troubleshoot.
    • According to the forum discussions, it is known by the community that some examples won't work, but that using the client works well.

Note: the subsequent PR will require this change to allow users to refresh their workbooks.

How I Tested These Changes

BK with updated tests

Changelog

NOCHANGELOG

  • NEW (added new feature or capability)
  • BUGFIX (fixed a bug)
  • DOCS (added or updated documentation)

Copy link
Contributor Author

maximearmstrong commented Sep 26, 2024

@maximearmstrong maximearmstrong force-pushed the maxime/use-tableau-server-client-for-dagster-tableau branch from 16eeed9 to 4d5429f Compare October 2, 2024 19:12
@maximearmstrong maximearmstrong force-pushed the maxime/use-tableau-server-client-for-dagster-tableau branch from 4d5429f to ad95ae9 Compare October 2, 2024 19:39
@maximearmstrong maximearmstrong merged commit 8cbf8a4 into master Oct 2, 2024
2 checks passed
@maximearmstrong maximearmstrong deleted the maxime/use-tableau-server-client-for-dagster-tableau branch October 2, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants