[dagster-tableau] Use tableauserverclient
#24826
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Updates
dagster-tableau
to usetableauserverclient
instead ofrequests
.Our first implementation leveraged requests, as suggested in their Tableau REST API documentation website and samples, see here and here.
Tableau provides a python client for their APIs, which is not mentioned on their REST API documentation website, but can be found here, docs here.
The library seems to be maintained only a few times a year, but the main reasons for using
tableauserverclient
instead ofrequests
are:requests
and following their documentation here and here, I wasn't able query their update workbook now endpoint without receiving a HTTP error 400 without much information to troubleshoot.Note: the subsequent PR will require this change to allow users to refresh their workbooks.
How I Tested These Changes
BK with updated tests
Changelog
NOCHANGELOG
NEW
(added new feature or capability)BUGFIX
(fixed a bug)DOCS
(added or updated documentation)