[ui] Fix logs toolbar step selector width #25048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 1af74f9. |
salazarm
approved these changes
Oct 3, 2024
hellendag
force-pushed
the
dish/logs-suggest
branch
from
17b077b
to
1af74f9
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The Blueprint upgrade broke the step selector in the Run logs toolbar. Fix it by giving it a container with some width.
It would probably make sense to try to clean up the
GlobalSuggestStylestyles to see if they can be simplified altogether, but I'm hesitant to risk breaking otherSuggestright this second.How I Tested These Changes
View Run, switch to stdout logs. Verify that the suggest component input has width.
Changelog
BUGFIX[ui] Fixed width of step selector component in Run logs toolbar.