[dagster-airlift] refactor run execution params #25088
Open
+58
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 4, 2024
schrockn
reviewed
Oct 4, 2024
Comment on lines
+122
to
+134
| def get_attribute_from_airflow_context(self, context: Context, attribute: str) -> Any: | ||
| if attribute not in context or context[attribute] is None: | ||
| raise Exception(f"Attribute {attribute} not found in context.") | ||
| return context[attribute] | ||
|
|
||
| def get_airflow_dag_run_id(self, context: Context) -> str: | ||
| return self.get_attribute_from_airflow_context(context, "dag_run").run_id | ||
|
|
||
| def get_airflow_dag_id(self, context: Context) -> str: | ||
| return self.get_attribute_from_airflow_context(context, "dag_run").dag_id | ||
|
|
||
| def get_airflow_task_id(self, context: Context) -> str: | ||
| return self.get_attribute_from_airflow_context(context, "task").task_id |
There was a problem hiding this comment.
to constrast from the previous PR, get is appropriate here since it is in-memory/cheap
schrockn
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Factor out run execution parameterization + run tags
How I Tested These Changes
existing
Changelog
NOCHANGELOG