-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-655 Docs for updated asset selection syntax #27672
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: nikki everett <[email protected]>
…assets docs, link to new asset selection syntax doc Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
docs/src/code-examples-content.js
Outdated
@@ -1,610 +0,0 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleting this seems unintentional ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is rebuilt in production, so doesn't need to be checked in (although checking it in won't cause any harm)
Hmm, I kind of want the path examples to stand out a bit more, It's lost in the sea of examples and I think when people see it a lightbulb will go off on their head that maybe we should move it to the top? |
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
docs/docs/guides/build/assets/asset-selection-syntax/reference.md
Outdated
Show resolved
Hide resolved
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
Signed-off-by: nikki everett <[email protected]>
docs/docs/guides/build/assets/asset-selection-syntax/reference.md
Outdated
Show resolved
Hide resolved
Signed-off-by: nikki everett <[email protected]>
Co-authored-by: Marco polo <[email protected]>
Co-authored-by: Marco polo <[email protected]>
sidebar_position: 100 | ||
--- | ||
|
||
This page contains common example asset selection queries and their implementation in Python, CLI, and the Dagster UI. For a full explanation of the filters, layers, operands, and functions that you can use to construct your own queries, see "[Asset selection syntax reference](reference)". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first page in the dropdown and immediately directs you to the second page, so maybe the reference should go first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I can put the reference page first -- I put the examples page first in order to make the path examples as prominent as possible, but those should be easier to find now that they're at the top of the page, regardless of the page's position in the sidebar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I like this better!
Signed-off-by: nikki everett <[email protected]>
Summary & Motivation
Updates "Asset selection syntax" doc with the new asset selection syntax.
How I Tested These Changes
Local build.
Changelog