Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow state in upvotes modal #3604

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

capJavert
Copy link
Contributor

@capJavert capJavert commented Sep 30, 2024

Changes

Use the same hook from source members list to correctly show follow state in upvotes modal.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://fix-follow-mutation-upvotes.preview.app.daily.dev

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 1:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
storybook ⬜️ Ignored (Inspect) Sep 30, 2024 1:05pm

typeof useMutationSubscription
>;

export const useSquadMembersContentPreferenceMutationSubscription = ({
export const useUsersContentPreferenceMutationSubscription = ({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just renamed and made more generic

@rebelchris rebelchris merged commit 2cc7d85 into main Sep 30, 2024
11 checks passed
@rebelchris rebelchris deleted the fix-follow-mutation-upvotes branch September 30, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants