Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated post char limit to 10,000 #2374

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

ilasw
Copy link
Contributor

@ilasw ilasw commented Oct 31, 2024

No description provided.

Copy link
Member

@sshanzel sshanzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing left is to update the test to ensure the workability 🥳

src/common/post.ts Outdated Show resolved Hide resolved
src/schema/posts.ts Outdated Show resolved Hide resolved
src/schema/posts.ts Outdated Show resolved Hide resolved
test: updated test for char limit
@ilasw
Copy link
Contributor Author

ilasw commented Oct 31, 2024

@capJavert @sshanzel updated ✅

@ilasw ilasw merged commit 18d3e6f into main Oct 31, 2024
8 checks passed
@ilasw ilasw deleted the feat-increase-post-char-limit branch October 31, 2024 09:54
rebelchris added a commit that referenced this pull request Nov 4, 2024
Addressing dailydotdev/daily#1533

It turns out the character count update was already included in this PR:
#2374. Only the test was
missing.

Co-authored-by: Chris Bongers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants