-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add block mutations #2377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking
_: true, | ||
}; | ||
}, | ||
block: async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure, but do we also need to introduce the other side backward compatibility?
So the current block flow to set contentPreference?
(Maybe you did this in other PR already, can't recall)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did add it, blockKeyword
also saves to Feedtag
with blocked: true
and blockSource
saves to FeedSource
.
Do we do anything additional with blocking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One question though, why does blocking and unblocking looks similar in terms of notificationPreference
. They both have 0 entry on that entity, shouldn't we add an entry with blocked = true
so that even default notifications won't be sent as they are blocked, if I understand correctly.
@sshanzel in both cases we wont to remove all notification preferences so user is not subscribed to anything, does that make sense?
We do add |
Thank you for the clarity, yeah, I was just wondering if it should also be the case for |
@sshanzel yeah, currently you can't block an user (at least from UI) so it will be a silent feature, but for sure good idea for when we want to introduce it. |
@Column({ type: 'text', default: SourceMemberRoles.Member }) | ||
role: SourceMemberRoles; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving role in db for now so I can copy data
AS-651