mobile: use bitrefill new parse #1366
Merged
+70
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nalinbhardwaj
force-pushed
the
nibnalin/bitrefill-fix
branch
2 times, most recently
from
7882652
to
39ef9d5
Compare
nalinbhardwaj
force-pushed
the
nibnalin/bitrefill-fix
branch
2 times, most recently
from
6f0174b
to
f0a7e87
Compare
dcposch
reviewed
Nov 5, 2024
| @@ -13,7 +13,7 @@ export type Action = | |||
| | { name: "createBackup" } | |||
| | { name: "hideBottomSheet" } | |||
| | { name: "swap"; swap: ProposedSwap } | |||
| | { name: "bitrefill"; address: Address; amount: DollarStr }; | |||
| | { name: "bitrefill"; address: Address; amount: BigIntStr }; | |||
dcposch
reviewed
Nov 5, 2024
|
|
||
| return { | ||
| recipientAddress: getAddress(recipientAddress), | ||
| amount: BigInt(Number(amount)).toString() as BigIntStr, |
There was a problem hiding this comment.
i think BigInt(Number(amount)) can be slightly off due to double precision
There was a problem hiding this comment.
saw it gets rounded up anyway in BitrefillBottomSheet..
There was a problem hiding this comment.
also, actually it's totally fine for USDC. issue only happens with 18-decimal tokens
dcposch
reviewed
Nov 5, 2024
| address, | ||
| amount: params.get("amount") || "", | ||
| }); | ||
| const parsedUri = parsePaymentUri(paymentUri); |
dcposch
reviewed
Nov 5, 2024
| expect(uri.recipientAddress).toEqual( | ||
| "0xaCB6230043d1Fc3dE02a43Aa748540bb9F260931" | ||
| ); | ||
| expect(uri.amount).toEqual("100000000"); |
nalinbhardwaj
force-pushed
the
nibnalin/bitrefill-fix
branch
from
f0a7e87
to
e8cbc55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1356