better detection of broken connections #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test::Routine::Common 0.25 provides stub BUILD/DEMOLISH methods for modifying, which means the ones provided by the RunTestApp* roles don't get applied. Instead, provide stubs (for older Test::Routine), and do the actual work in an 'after' modifier instead.
Instead of waiting for a specific amount of time, wait for the server to actually create the trace subdirectories.
we can now request a receipt for each ACK we send, and if we don't get it within a short timeout, we declare the connection dead there's a complication: RECEIPTs will arrive mixed in with MESSAGEs, so we have to keep track of which receipts we're waiting for
dakkar
force-pushed
the
ack-with-receipt
branch
from
2633f60 to
8ff7659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we can now request a receipt for each ACK we send, and if we don't get
it within a short timeout, we declare the connection dead
there's a complication: RECEIPTs will arrive mixed in with MESSAGEs, so
we have to keep track of which receipts we're waiting for