Skip to content

Commit

Permalink
fix: kafka bindings not using latest version
Browse files Browse the repository at this point in the history
cf. spotted in a comment in
asyncapi#481

Signed-off-by: Dale Lane <[email protected]>
  • Loading branch information
dalelane committed Mar 14, 2024
1 parent b4841e4 commit 724f409
Show file tree
Hide file tree
Showing 4 changed files with 58 additions and 6 deletions.
17 changes: 15 additions & 2 deletions definitions/3.0.0/channelBindingsObject.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"kafka": {
"properties": {
"bindingVersion": {
"enum": ["0.4.0", "0.3.0"]
"enum": ["0.5.0", "0.4.0", "0.3.0"]
}
},
"allOf": [
Expand All @@ -98,7 +98,20 @@
}
},
"then": {
"$ref": "http://asyncapi.com/bindings/kafka/0.4.0/channel.json"
"$ref": "http://asyncapi.com/bindings/kafka/0.5.0/channel.json"
}
},
{
"if": {
"required": [ "bindingVersion" ],
"properties": {
"bindingVersion": {
"const": "0.5.0"
}
}
},
"then": {
"$ref": "http://asyncapi.com/bindings/kafka/0.5.0/channel.json"
}
},
{
Expand Down
17 changes: 15 additions & 2 deletions definitions/3.0.0/messageBindingsObject.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
"kafka": {
"properties": {
"bindingVersion": {
"enum": ["0.4.0", "0.3.0"]
"enum": ["0.5.0", "0.4.0", "0.3.0"]
}
},
"allOf": [
Expand All @@ -145,7 +145,20 @@
}
},
"then": {
"$ref": "http://asyncapi.com/bindings/kafka/0.4.0/message.json"
"$ref": "http://asyncapi.com/bindings/kafka/0.5.0/message.json"
}
},
{
"if": {
"required": [ "bindingVersion" ],
"properties": {
"bindingVersion": {
"const": "0.5.0"
}
}
},
"then": {
"$ref": "http://asyncapi.com/bindings/kafka/0.5.0/message.json"
}
},
{
Expand Down
15 changes: 14 additions & 1 deletion definitions/3.0.0/operationBindingsObject.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,20 @@
}
},
"then": {
"$ref": "http://asyncapi.com/bindings/kafka/0.4.0/operation.json"
"$ref": "http://asyncapi.com/bindings/kafka/0.5.0/operation.json"
}
},
{
"if": {
"required": [ "bindingVersion" ],
"properties": {
"bindingVersion": {
"const": "0.5.0"
}
}
},
"then": {
"$ref": "http://asyncapi.com/bindings/kafka/0.5.0/operation.json"
}
},
{
Expand Down
15 changes: 14 additions & 1 deletion definitions/3.0.0/serverBindingsObject.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,20 @@
}
},
"then": {
"$ref": "http://asyncapi.com/bindings/kafka/0.4.0/server.json"
"$ref": "http://asyncapi.com/bindings/kafka/0.5.0/server.json"
}
},
{
"if": {
"required": [ "bindingVersion" ],
"properties": {
"bindingVersion": {
"const": "0.5.0"
}
}
},
"then": {
"$ref": "http://asyncapi.com/bindings/kafka/0.5.0/server.json"
}
},
{
Expand Down

0 comments on commit 724f409

Please sign in to comment.