Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for badly behaving RGB smart lights with HomeKit color picker #17

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix for badly behaving RGB smart lights with HomeKit color picker #17

wants to merge 8 commits into from

Commits on Oct 10, 2020

  1. Added 3 optional settings to the config that help tremendously with m… 

    …y inovelli smartlights to stop sending mulitple commands to set the color or level. By default when either the level or color is changed, homekit will send an on and setLevel command or a setHue and setSaturation command. This can cause the light to flicker as it cycles between both settings. In the worse case scenario, it appears that homekit will get confused and switch the hue and saturation back and forth and not set the combined command values when sending both as invidual comamnds. This changes the plugin to look to see if two compatible commands are sent in very close proximity of each other. It delays sending the first one until the second is recieved, then sends a setColor command, if a second command isn't recieved within 50ms (configurable) or so, it sends just the first command by itself. If none of the config values are specified, the default behavior isn't changed.

New config values are below:
            "use_set_color": true,  // This turns on setColor processing and will combine setHue and setSaturation commands that are recieved within dedupe_command_delay_ms of each other
            "dedupe_command_delay_ms": 10, // The amount of time to wait for a second command
            "squash_on_commands": ["setLevel"] // This is a list of commands that receive an 'on' command before a setLevel, this will squash the on command and just send a setLevel command
    Chuck Holbrook committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    465a4b7 View commit details
    Browse the repository at this point in the history

  2. Removed debugging code

    Chuck Holbrook committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    2ee7cf8 View commit details
    Browse the repository at this point in the history

  3. Undoing package.json changes

    Chuck Holbrook committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    e925212 View commit details
    Browse the repository at this point in the history

  4. Updating package.json version

    Chuck Holbrook committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    e993547 View commit details
    Browse the repository at this point in the history

  5. Undoing package.json changes

    Chuck Holbrook committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    5b6c052 View commit details
    Browse the repository at this point in the history

  6. Added dedupe_change_events_ms config value, updated readme.md

    Chuck Holbrook committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    a468b77 View commit details
    Browse the repository at this point in the history

  7. Fix to update change events for http calls too

    Chuck Holbrook committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    a592801 View commit details
    Browse the repository at this point in the history

  8. Undoing package.json changes

    Chuck Holbrook committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    caa405f View commit details
    Browse the repository at this point in the history