Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify our current search engine #108

Closed
danbugs opened this issue Feb 22, 2024 · 4 comments · Fixed by #112
Closed

Modify our current search engine #108

danbugs opened this issue Feb 22, 2024 · 4 comments · Fixed by #112
Assignees
Labels
feature new feature

Comments

@danbugs
Copy link
Owner

danbugs commented Feb 22, 2024

Describe the solution you'd like
This involves two things:
(1) I'd like exact matches of a tag searched to display at the top (e.g., when searching "tenant", we should get the result exactly matching that on the first page rather than on the third one behind tons of "lieutenants").
(2) Allow to search by ID/user slug (related to #106)

Additional context
n/a

@danbugs danbugs added the feature new feature label Feb 22, 2024
@danbugs danbugs assigned danbugs and unassigned danbugs Feb 22, 2024
@CERLgit
Copy link
Contributor

CERLgit commented Feb 23, 2024

Since start.gg allows gamertags containing nothing but numbers, I will try to have them listed in this order:

ID exact match (if all numbers, otherwise skip),
slug exact match,
gamertag exact match,
gamertag similar matches.

This should cover all cases without having separate boxes/filters. Let me know if I'm missing something

@danbugs
Copy link
Owner Author

danbugs commented Feb 23, 2024

Yeah, that sounds good to me - Another option to consider is adding text filters to the search, like specifying smt like an "id:" prefix when searching by ID (e.g., "id:123456"), but I'll leave that up to you 👍

@CERLgit
Copy link
Contributor

CERLgit commented Feb 23, 2024

Yeah, that sounds good to me - Another option to consider is adding text filters to the search, like specifying smt like an "id:" prefix when searching by ID (e.g., "id:123456"), but I'll leave that up to you 👍

I didn't want to do this because I don't know exactly what characters start.gg allows/doesn't.
For example this account has an underscore and semicolon
https://www.start.gg/user/aed08833
If colons are allowed and someone was to name themselves "tag:test" and tried searching for it, they'd get the account named test instead of their own

@danbugs
Copy link
Owner Author

danbugs commented Feb 23, 2024

Yep - that's a fair concern. I like the approach you mentioned prior 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants