-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search Engine Improvements #112
Conversation
Signed-off-by: Carlos R <[email protected]>
Signed-off-by: Carlos R <[email protected]>
Signed-off-by: Carlos R <[email protected]>
Signed-off-by: Carlos R <[email protected]>
Signed-off-by: Carlos R <[email protected]>
Signed-off-by: Carlos R <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
- Coverage 14.85% 14.79% -0.07%
==========================================
Files 24 24
Lines 1494 1501 +7
==========================================
Hits 222 222
- Misses 1272 1279 +7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM - just one small change request :)
Signed-off-by: Carlos R <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks again for contributing ;D
Search can now use slug, tag and id.
Search now reports tags closest to input then finds the shortest one, which will always be the one which matches
the input exactly. If tags are equal length, older account (smaller PID) will come first. This assumes the OG will always have made their account first to prevent showing impersonators before expected player. Closes #108