Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Engine Improvements #112

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Search Engine Improvements #112

merged 8 commits into from
Feb 26, 2024

Conversation

CERLgit
Copy link
Contributor

@CERLgit CERLgit commented Feb 26, 2024

Search can now use slug, tag and id.
Search now reports tags closest to input then finds the shortest one, which will always be the one which matches
the input exactly. If tags are equal length, older account (smaller PID) will come first. This assumes the OG will always have made their account first to prevent showing impersonators before expected player. Closes #108

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Merging #112 (258056f) into main (0052958) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   14.85%   14.79%   -0.07%     
==========================================
  Files          24       24              
  Lines        1494     1501       +7     
==========================================
  Hits          222      222              
- Misses       1272     1279       +7     

Copy link
Owner

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM - just one small change request :)

lib/src/player.rs Outdated Show resolved Hide resolved
Signed-off-by: Carlos R <[email protected]>
Copy link
Owner

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks again for contributing ;D

@danbugs danbugs merged commit 6d3ada3 into danbugs:main Feb 26, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify our current search engine
2 participants