Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-record VCR tapes using newer versions of libraries #1337

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Commits on Oct 16, 2023

  1. Re-record VCR tapes using newer versions of libraries

    I believe that somehow some upgrade among
    
    ❯ wdiff -3 /tmp/f1 /tmp/f2
    
    ======================================================================
    [-06/github/cron/20231006T060312/0c1d4a0/Tests/5197/test-]{+07/github/cron/20231007T060245/0c1d4a0/Tests/5198/test+}
    ======================================================================
     [-dependencies.txt:2023-10-06T06:05:18.6948668Z-] {+dependencies.txt:2023-10-07T06:04:51.1091526Z+}
    ======================================================================
     [-boto3-1.28.61 botocore-1.31.61-] {+boto3-1.28.62 botocore-1.31.62+}
    ======================================================================
     [-entrypoints-0.4-]
    ======================================================================
     [-numcodecs-0.11.0-] {+numcodecs-0.12.0+}
    ======================================================================
     [-urllib3-1.26.17-] {+urllib3-2.0.6+}
    ======================================================================
    
    (so likely urllib3) lead to drastically different behavior which triggered
    VCR to try to not reuse prior tape but then subsequent dialog started to
    fail -- we got no json.  As you can see in the diff we observe that
    now we do get json (as requested) recorded although previously
    it was some "binary".
    yarikoptic committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4fe7c39 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    25bd01c View commit details
    Browse the repository at this point in the history