Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop claiming support and testing against EOL Python 3.8 #1504

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Sep 27, 2024

Fixes #1503

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (d5c4a3f) to head (fb076c8).
Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
+ Coverage   88.56%   88.64%   +0.08%     
==========================================
  Files          77       77              
  Lines       10572    10572              
==========================================
+ Hits         9363     9372       +9     
+ Misses       1209     1200       -9     
Flag Coverage Δ
unittests 88.64% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

not yet, in a month or so whenever it actually EOLs

@asmacdo asmacdo changed the title Drop Python 3.8 EOL (2024-10) Drop Python 3.8 EOL (Do not merge until 2024-10-14) Sep 27, 2024
@asmacdo asmacdo marked this pull request as draft September 27, 2024 17:34
@asmacdo
Copy link
Member Author

asmacdo commented Sep 27, 2024

The 3.12 Test breaking is unrelated, its just a flake.

I bumped the timeout here fwiw.

@asmacdo asmacdo changed the title Drop Python 3.8 EOL (Do not merge until 2024-10-14) Drop Python 3.8 EOL Oct 9, 2024
@asmacdo asmacdo marked this pull request as ready for review October 9, 2024 14:32
@asmacdo
Copy link
Member Author

asmacdo commented Oct 9, 2024

I thought it was EOL on October 14, but its gone as of October 7. https://devguide.python.org/versions/

@yarikoptic
Copy link
Member

Thank you! I am also going through similar fun activities in other corners

@yarikoptic yarikoptic added the patch Increment the patch version when merged label Oct 14, 2024
@yarikoptic yarikoptic changed the title Drop Python 3.8 EOL Drop claiming support and testing against EOL Python 3.8 Oct 14, 2024
@yarikoptic yarikoptic merged commit 8ec8db5 into dandi:master Oct 14, 2024
22 of 23 checks passed
Copy link

🚀 PR was released in 0.64.0 🚀

Copy link

🚀 PR was released in 0.64.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.8 tests failing
2 participants