Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: more consistent and exhaustive logging, new DANDI_DEVEL_AGGRESSIVE_RETRY mode, respect (?) Retry-After #1509

Merged
merged 17 commits into from
Nov 15, 2024

fix(workaround,test): completely skip running test_DownloadDirectory_…

7f97394
Select commit
Loading
Failed to load commit list.
Merged

download: more consistent and exhaustive logging, new DANDI_DEVEL_AGGRESSIVE_RETRY mode, respect (?) Retry-After #1509

fix(workaround,test): completely skip running test_DownloadDirectory_…
7f97394
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 14, 2024 in 1s

88.51% (-0.08%) compared to 6aa414c

View this Pull Request on Codecov

88.51% (-0.08%) compared to 6aa414c

Details

Codecov Report

Attention: Patch coverage is 72.72727% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (6aa414c) to head (7f97394).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
dandi/download.py 35.71% 27 Missing ⚠️
dandi/cli/command.py 0.00% 1 Missing ⚠️
dandi/dandiapi.py 80.00% 1 Missing ⚠️
dandi/tests/test_download.py 98.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
- Coverage   88.58%   88.51%   -0.08%     
==========================================
  Files          78       78              
  Lines       10589    10689     +100     
==========================================
+ Hits         9380     9461      +81     
- Misses       1209     1228      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.