Merge pull request #262 from dandi/rf-3.9

Drop Python 3.8 support (remove typing_extensions from depends)

.github/workflows/lint.yml

@@ -16,7 +16,7 @@ jobs:
     - name: Set up Python
       uses: actions/setup-python@v5
       with:
-        python-version: '3.8'
+        python-version: '3.9'
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip

.github/workflows/release.yml

@@ -58,7 +58,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: 3.8
+          python-version: 3.9
 
       - name: Install dandischema
         run: python -m pip install .

.github/workflows/test-dandi-cli.yml

@@ -24,23 +24,22 @@ jobs:
           - macos-latest
         python:
           # Use the only Python which is ATM also used by dandi-api
-          # - 3.7
-          # - 3.8
           # - 3.9
           # - '3.10'
           - '3.11'
+          # - '3.12'
         version:
           - master
           - release
         mode:
           - normal
         include:
           - os: ubuntu-latest
-            python: 3.8
+            python: 3.9
             mode: dandi-devel
             version: master
           - os: ubuntu-latest
-            python: 3.8
+            python: 3.9
             mode: dandi-devel
             version: release
         exclude:

.github/workflows/test-nonetwork.yml

@@ -17,9 +17,8 @@ jobs:
         os:
           - windows-2019
           - ubuntu-latest
-          - macos-12
+          - macos-latest
         python:
-          - 3.8
           - 3.9
           - '3.10'
           - '3.11'

.github/workflows/test-schema.yml

@@ -19,7 +19,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.8'
+          python-version: '3.9'
 
       - name: Install dandischema
         run: python -m pip install .

.github/workflows/test.yml

@@ -18,9 +18,8 @@ jobs:
         os:
           - windows-2019
           - ubuntu-latest
-          - macos-12
+          - macos-latest
         python:
-          - 3.8
           - 3.9
           - '3.10'
           - '3.11'

.github/workflows/typing.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
-          python-version: '3.8'
+          python-version: '3.9'
 
       - name: Install dependencies
         run: |

dandischema/models.py

@@ -4,7 +4,18 @@
 from enum import Enum
 import os
 import re
-from typing import Any, Dict, List, Literal, Optional, Sequence, Type, TypeVar, Union
+from typing import (
+    Annotated,
+    Any,
+    Dict,
+    List,
+    Literal,
+    Optional,
+    Sequence,
+    Type,
+    TypeVar,
+    Union,
+)
 from warnings import warn
 
 from pydantic import (
@@ -23,9 +34,6 @@
 )
 from pydantic.json_schema import JsonSchemaValue
 from pydantic_core import CoreSchema
-from typing_extensions import (
-    Annotated,  # TODO: import from `typing` when Python 3.8 support is dropped
-)
 from zarr_checksum.checksum import InvalidZarrChecksum, ZarrDirectoryDigest
 
 from .consts import DANDI_SCHEMA_VERSION

dandischema/types.py

@@ -1,12 +1,11 @@
 # This file is for defining types that extend existing types through the use of
 # `typing.Annotated`.
 
-from typing import Type
+from typing import Annotated, Type
 
 from pydantic import ByteSize, GetCoreSchemaHandler, GetJsonSchemaHandler
 from pydantic.json_schema import JsonSchemaValue
 from pydantic_core import CoreSchema, core_schema
-from typing_extensions import Annotated
 
 
 class _ByteSizeJsonSchemaAnnotation:

setup.cfg

@@ -12,7 +12,6 @@ classifiers =
     License :: OSI Approved :: Apache Software License
     Operating System :: OS Independent
     Programming Language :: Python
-    Programming Language :: Python :: 3.8
     Programming Language :: Python :: 3.9
     Programming Language :: Python :: 3.10
     Programming Language :: Python :: 3.11
@@ -27,12 +26,11 @@ project_urls =
     Source Code = https://github.com/dandi/dandischema
 
 [options]
-python_requires = >=3.8
+python_requires = >=3.9
 install_requires =
     jsonschema[format]
     pydantic[email] ~= 2.4
     requests
-    typing_extensions; python_version < "3.9"
     zarr_checksum
 zip_safe = False
 packages = find_namespace: