-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code for calculating Zarr checksums #209
Labels
Comments
jwodder
added a commit
to dandi/dandi-cli
that referenced
this issue
Dec 8, 2023
jwodder
added a commit
to dandi/dandi-cli
that referenced
this issue
Dec 8, 2023
jwodder
added a commit
to dandi/dandi-cli
that referenced
this issue
Dec 8, 2023
And rewrite it in terms of `zarr_checksum` Part of dandi/dandi-schema#209
jwodder
added a commit
to dandi/dandi-archive
that referenced
this issue
Dec 8, 2023
NB: asking in https://github.com/dandi/dandi-cli/pull/1371/files#r1420705289 on either we could/should reuse a higher level constructs in zarr_checksum |
Removal of the Zarr code from dandischema will require rewriting the code for extracting total size from a Zarr checksum. This will mean adding
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that we have
zarr_checksum
, having a separate module for checksumming Zarrs in dandischema is redundant.dandischema.digests.zarr
withzarr_checksum
dandi/files/zarr.py
dandischema.digests.zarr.get_checksum()
to dandi-cli: use zarr_checksum library constructs instead of copies in dandischema dandi-cli#1371dandiapi/zarr/tests/test_zarr.py
test_zarr.py
: ImportEMPTY_CHECKSUM
fromzarr_checksum
dandi-archive#1775dandischema/models.py
dandischema.digests.zarr
and its test codeThe text was updated successfully, but these errors were encountered: