Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for calculating Zarr checksums #209

Closed
2 of 5 tasks
jwodder opened this issue Dec 8, 2023 · 2 comments · Fixed by #217
Closed
2 of 5 tasks

Remove code for calculating Zarr checksums #209

jwodder opened this issue Dec 8, 2023 · 2 comments · Fixed by #217

Comments

@jwodder
Copy link
Member

jwodder commented Dec 8, 2023

Now that we have zarr_checksum, having a separate module for checksumming Zarrs in dandischema is redundant.

@yarikoptic
Copy link
Member

NB: asking in https://github.com/dandi/dandi-cli/pull/1371/files#r1420705289 on either we could/should reuse a higher level constructs in zarr_checksum

@jwodder
Copy link
Member Author

jwodder commented Jan 4, 2024

Removal of the Zarr code from dandischema will require rewriting the code for extracting total size from a Zarr checksum. This will mean adding zarr_checksum as a dependency to dandischema, but:

jwodder added a commit that referenced this issue Jan 23, 2024
jwodder added a commit that referenced this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants