Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Zarr checksum code #217

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Remove Zarr checksum code #217

merged 1 commit into from
Feb 12, 2024

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 23, 2024

Closes #209.

@jwodder jwodder added the minor Increment the minor version when merged label Jan 23, 2024
@jwodder jwodder requested a review from satra January 23, 2024 20:06
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08d92c8) 97.66% compared to head (87db400) 97.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   97.66%   97.54%   -0.13%     
==========================================
  Files          18       16       -2     
  Lines        1799     1669     -130     
==========================================
- Hits         1757     1628     -129     
+ Misses         42       41       -1     
Flag Coverage Δ
unittests 97.54% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwodder
Copy link
Member Author

jwodder commented Feb 12, 2024

@satra Ping.

Copy link
Member

@satra satra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to release

comment made in error.

@jwodder jwodder added the release Create a release when this pr is merged label Feb 12, 2024
@jwodder jwodder merged commit 94516c5 into master Feb 12, 2024
69 of 77 checks passed
@jwodder jwodder deleted the rm-zarr-code branch February 12, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code for calculating Zarr checksums
2 participants