Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPT: (memory) cache schema files upon first read from github #213

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

yarikoptic
Copy link
Member

Transpired by looking at never finalized

as a much less intrusive and simpler approach to avoid repetitive requests for the same schema files.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9d7f89) 97.71% compared to head (e780174) 97.72%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   97.71%   97.72%           
=======================================
  Files          17       17           
  Lines        1752     1755    +3     
=======================================
+ Hits         1712     1715    +3     
  Misses         40       40           
Flag Coverage Δ
unittests 97.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Transpired by looking at never finalized
#155
as a much less intrusive and simpler approach to avoid repetative requests
for the same schema files.
@jwodder jwodder added the minor Increment the minor version when merged label Dec 18, 2023
@jwodder jwodder added performance Improve performance of an existing feature and removed minor Increment the minor version when merged labels Dec 18, 2023
@yarikoptic
Copy link
Member Author

FWIW restarted for errored out windows

================================== FAILURES ===================================
____________________________ test_datacite[000008] ____________________________
dandischema\tests\test_datacite.py:156: in test_datacite
    datacite_post(datacite, meta.doi)
dandischema\tests\test_datacite.py:30: in datacite_post
    rp.raise_for_status()
.tox\py\Lib\site-packages\requests\models.py:1021: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
E   requests.exceptions.HTTPError: 422 Client Error: Unprocessable Entity for url: https://api.test.datacite.org/dois

---------- coverage: platform win32, python 3.11.7-final-0 -----------
Coverage XML written to file coverage.xml

@yarikoptic
Copy link
Member Author

was approved, so let's proceed

@yarikoptic yarikoptic merged commit fcd0ba8 into master Jan 22, 2024
79 checks passed
@yarikoptic yarikoptic deleted the enh-cache-schema branch January 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Improve performance of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants