Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #219

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Jan 29, 2024

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4423b41) 97.66% compared to head (ab58ab8) 97.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files          18       18           
  Lines        1798     1798           
=======================================
  Hits         1756     1756           
  Misses         42       42           
Flag Coverage Δ
unittests 97.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member

@jwodder WDYT? should we go ahead with it or somehow tune config to avoid side-effects from upgrade?

@jwodder
Copy link
Member

jwodder commented Feb 7, 2024

@yarikoptic

somehow tune config to avoid side-effects from upgrade?

Do you mean somehow suppressing the formatting changes due to the new version of black? Why would we want to do that?

@yarikoptic
Copy link
Member

in principle -- to avoid possible conflicts with other outstanding PRs

@jwodder
Copy link
Member

jwodder commented Feb 7, 2024

@yarikoptic Unless there's a way to trigger an update of this PR later (Is there?), I think it'd be easiest to merge this as soon as possible, then update all other outstanding PRs via rebasing and running pre-commit run -a.

@yarikoptic yarikoptic merged commit 08d92c8 into master Feb 7, 2024
65 of 76 checks passed
@yarikoptic yarikoptic deleted the pre-commit-ci-update-config branch February 7, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants