Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring model so we could avoid shortcoming of linkml model #257

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactoring model so we could avoid shortcoming of linkml model #257

wants to merge 3 commits into from
+5 −5

Commits on Oct 31, 2024

  1. [DATALAD RUNCMD] Replace Union[Any, List[Any]] with just Any 

    since Any also represents List or anything else really.
I thought that it might be used somewhere in the meditor to edit dandiset metadata
but it seems that nothing of that type propagated into dandiset metadata so
it should not be effected

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'Union\\[Any, List\\[Any\\]\\]' Any",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
    @yarikoptic
    yarikoptic committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    6d4bacc View commit details
    Browse the repository at this point in the history

  2. Make identifier singular (remove possibility for a list of identifier… 

    …s) for Locus and Allele

So far I see no values with such data types used at all in dandi archive so we should not
break anything

An alternative would be to just make it a List[Identifier] always and not
bother allowing for the dance of singular-vs-plural.
    @yarikoptic
    yarikoptic committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    50b63c0 View commit details
    Browse the repository at this point in the history

  3. Remove possibility for listing multiple GenotypeInfo for "genotype" 

    That would avoid Union of a list with non-multivalued identifier. And we already have
data with string value describing the genotype -- it is not really an identifier!!!
    @yarikoptic
    yarikoptic committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b2205ac View commit details
    Browse the repository at this point in the history