Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: A comment on current identification of URI and missing space into a description string #265

Merged
merged 1 commit into from
Nov 18, 2024
+2 −1
Merged

doc: A comment on current identification of URI and missing space into a description string #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dandischema/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@ def __get_pydantic_json_schema__(
if value.get("title") is None or value["title"] == prop.title():
value["title"] = name2title(prop)
if re.match("\\^https?://", value.get("pattern", "")):
# triggers only for ROR in identifier
value["format"] = "uri"
if value.get("format", None) == "uri":
value["maxLength"] = 1000
Expand Down Expand Up @@ -623,7 +624,7 @@ class PropertyValue(DandiBaseModel):
) # Note: recursive (circular or not)
propertyID: Optional[Union[IdentifierType, AnyHttpUrl]] = Field(
None,
description="A commonly used identifier for"
description="A commonly used identifier for "
"the characteristic represented by the property. "
"For example, a known prefix like DOI or a full URL.",
json_schema_extra={"nskey": "schema"},
Expand Down