Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisProvider - Remove the actual event record if we're tidying up after ourselves. #1187

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ChrisBertrand
Copy link

Describe the change
Following the _removeComplete logic on PersistWorkflow, also remove events if this is set.

Describe your implementation or design
Followed the same logic from the PersistWorkflow method.

Tests
Tested locally.

Breaking change
No. There are no changes to the method signature or interface.

Additional context
This is really useful in the Redis provider as there is no cleanup functionality available, finding the right keys within the events hash key is rather difficult, having it as part of the main logic would simplify this.

Remove the actual event record if we're tidying up after ourselves.
Adding in logic to CreateEvent Method
@ChrisBertrand ChrisBertrand changed the title Patch 1 RedisProvider - Remove the actual event record if we're tidying up after ourselves. Jul 11, 2023
@ChrisBertrand
Copy link
Author

@danielgerlag Would be great to get feedback on this when you're next free. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant