Overload GetPendingActivity with workflowId parameter. Solves #542 issue. #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verload parameter allows the host to get only the pending activities from a specific workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
An overload on the
GetPendingActivityonActivityControllerto includeworkflowIdparameter, this overload allows the host to get only the pending activities from a specific workflow. Helping to solve the issue #542Describe your implementation or design
How did you go about implementing the change?
It's only a overload, follows the same implementation that the master branch, but now help the host to get pending activities with a new filter, the workflowId.
Tests
Did you cover your changes with tests?
Yes
Breaking change
Do you changes break compatibility with previous versions?
No
Additional context
This change is not supported only on Redis provider. I couldn't implements this overload for Redis.