-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build-sdk.sh #637
Update build-sdk.sh #637
Conversation
The install instruction does not work anymore, updated it with the new install instruction from https://github.com/oapi-codegen/oapi-codegen
WalkthroughThe changes involve an update to the installation command for the OpenAPI code generator in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BuildScript as Build Script
participant CodeGenerator as OpenAPI Code Generator
User->>BuildScript: Run build-sdk.sh
BuildScript->>CodeGenerator: Install oapi-codegen
CodeGenerator-->>BuildScript: Confirm installation
BuildScript-->>User: SDK generated successfully
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (2)docs/terminal/build-sdk.sh (2)Line range hint The script's workflow and commands remain valid with the new generator version. The consistent command structure (
The update to use the new repository location is correct and matches the official source. Let's verify the repository's authenticity and check for any breaking changes: ✅ Verification successfulLet me gather more information about the old repository to make a complete verification. Let me try one final verification to check the relationship between these repositories by looking at their git history. Repository update is correct and verified The change to
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the repository and its relationship with the old one
# Check if the old repository mentions migration
echo "Checking for migration notice in the old repository..."
gh repo view deepmap/oapi-codegen --json description,url,archived
# Check the new repository's information
echo "Verifying the new repository..."
gh repo view oapi-codegen/oapi-codegen --json description,url,stargazerCount,createdAt
Length of output: 1674 Script: #!/bin/bash
# Check the old repository's details and latest activity
gh repo view deepmap/oapi-codegen --json description,url,isArchived,stargazerCount,createdAt,pushedAt
# Check if there are any references to migration in the README of both repos
echo "Checking old repo's README..."
gh repo view deepmap/oapi-codegen --json readme | jq -r '.readme.text' | grep -i "migrat\|move\|transfer" || true
echo "Checking new repo's README..."
gh repo view oapi-codegen/oapi-codegen --json readme | jq -r '.readme.text' | grep -i "migrat\|move\|transfer" || true
Length of output: 2979 Script: #!/bin/bash
# Check if one repository is a fork of another or if they share history
echo "Checking repository relationships..."
gh repo view deepmap/oapi-codegen --json isFork,parent,nameWithOwner
gh repo view oapi-codegen/oapi-codegen --json isFork,parent,nameWithOwner
# Get the latest release information from both repos
echo "Checking latest releases..."
gh release list --repo deepmap/oapi-codegen --limit 1
gh release list --repo oapi-codegen/oapi-codegen --limit 1
Length of output: 709 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 22 22
Lines 4848 4848
=======================================
Hits 4504 4504
Misses 299 299
Partials 45 45 ☔ View full report in Codecov by Sentry. |
The install instruction does not work anymore, updated it with the new install instruction from https://github.com/oapi-codegen/oapi-codegen
Summary by CodeRabbit