Dont set group for optional fields (#528)

Fixes #523
danielgtaylor · Oct 16, 2023 · 8b5dd6c · 8b5dd6c
1 parent 3514991
commit 8b5dd6c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/betterproto/__init__.py b/src/betterproto/__init__.py
@@ -909,7 +909,7 @@ def dump(self, stream: BinaryIO) -> None:
             # Note that proto3 field presence/optional fields are put in a
             # synthetic single-item oneof by protoc, which helps us ensure we
             # send the value even if the value is the default zero value.
-            selected_in_group = bool(meta.group)
+            selected_in_group = bool(meta.group) or meta.optional
 
             # Empty messages can still be sent on the wire if they were
             # set (or received empty).

diff --git a/src/betterproto/plugin/models.py b/src/betterproto/plugin/models.py
@@ -385,7 +385,10 @@ def is_oneof(proto_field_obj: FieldDescriptorProto) -> bool:
         us to tell whether it was set, via the which_one_of interface.
     """
 
-    return which_one_of(proto_field_obj, "oneof_index")[0] == "oneof_index"
+    return (
+        not proto_field_obj.proto3_optional
+        and which_one_of(proto_field_obj, "oneof_index")[0] == "oneof_index"
+    )
 
 
 @dataclass