Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce serialize_empty for repeated fields #417

Merged
merged 5 commits into from
Aug 31, 2022

Conversation

sterliakov
Copy link
Contributor

When serializing a sequence of elements, serialize_empty must be True to prevent data loss and messages incompatible with original protobuf implementation.

Closes #414
Closes #387

Gobot1234
Gobot1234 previously approved these changes Aug 31, 2022
@sterliakov
Copy link
Contributor Author

Sorry, I haven't noticed .pre-commit-config, only black (and poe format) was mentioned in README. (Should I open a separate PR to document this and add setup.py with 2 lines to support editable pip-installs?)

@Gobot1234
Copy link
Collaborator

No, don't worry about it, I've fixed poe format in #415 and since this package uses poetry for development we don't need a setup.py to have an editable install

@sterliakov
Copy link
Contributor Author

Fixed.

@Gobot1234 Gobot1234 changed the title Enforce serialize_empty for collection elements Enforce serialize_empty for repeated fields Aug 31, 2022
@Gobot1234 Gobot1234 merged commit bfc0fac into danielgtaylor:master Aug 31, 2022
@Gobot1234
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants