Use external package betterproto-rust-codec for better (de-)serialization performance
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gobot1234
requested changes
Dec 4, 2023
cetanu
previously approved these changes
Dec 4, 2023
cetanu
reviewed
Dec 4, 2023
|
I see your point. Is it better now? |
Gobot1234
reviewed
Dec 5, 2023
Comment on lines
+1871
to
+1886
| # monkey patch (de-)serialization functions of class `Message` | ||
| # with functions from `betterproto-rust-codec` if available | ||
| try: | ||
| import betterproto_rust_codec | ||
|
|
||
| def __parse_patch(self: T, data: bytes) -> T: | ||
| betterproto_rust_codec.deserialize(self, data) | ||
| return self | ||
|
|
||
| def __bytes_patch(self) -> bytes: | ||
| return betterproto_rust_codec.serialize(self) | ||
|
|
||
| Message.parse = __parse_patch | ||
| Message.__bytes__ = __bytes_patch | ||
| except ModuleNotFoundError: | ||
| pass |
There was a problem hiding this comment.
I'd personally just do something along the lines of
HAS_ACCELERATOR = cast(Literal[False], importlib.util.find_spec("betterproto_rust_codec"))
if HAS_ACCELERATOR:
import betterproto_rust_codec
class Message:
def parse():...
def __bytes__():...
if HAS_ACCELERATOR:
parse = betterproto_rust_codec.deserialize # edit this so it returns self
__bytes__ = betterproto_rust_codec.serializebecause this reduces the number of call frames and looks significantly less hacky
There was a problem hiding this comment.
I don't really understand why, but directly assigning __bytes__ = betterproto_rust_codec.serialize does not work for some reason. So editing deserialize would probably not help either.
What do you think about this approach?
class Message:
if HAS_ACCELERATOR:
def parse(self, data):
...
else:
def parse(self, data):
...I think this might be even more transparent.
There was a problem hiding this comment.
I find that problematic because it's another level of indentation which is annoying especially with black. If the function isn't binding as a descriptor just leave it as is
This was referenced Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an alternative to #520. It uses the same Rust based extension module to improve (de-)serialization performance of
betterprotosignificantly. However, instead of integrating the extension into thebetterprotoproject, I published it to PyPi separately, and only referenced it here as an optional dependency. For this reason, this branch is ready to use as it is.