Read KEPLER AGB star and relax it with a sink. #626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 28, 2025 14:17
… get_accel_sink_gas now
…cles are used so that sink-gas force is correct
…tmass>0 in GR case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
modification to existing code + bug fix
Description:
We can now read KEPLER AGB stars and relax them with a sink particle.
There was a bug inside the substepping.f90 file for sink-gas force in GR which was fixed by using omp critical statement.
Inside setup_grtde.f90 we displace the sink particle as well.
Testing:
a sink + gas particles star orbit around each other
two sinks orbit around each other.
KEPLER AGB star setup around a BH in GR
Did you run the bots? no
Did you update relevant documentation in the docs directory? no