Remove undefined color enum case

danielsaidi · Feb 14, 2024 · 012803a · 012803a
1 parent 2ced875
commit 012803a
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 17 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -46,6 +46,10 @@ By deprecating these functions, we can simplify the library in 1.0, and focus mo
 * `RichTextCoordinator` functions that simply triggered `handle(_:)` have been deprecated.
 * `RTKL10n.bundle` has been deprecated, since we can just use the `.module` bundle from now.
 
+### 💥 Breaking Changes
+
+* `RichTextColor.undefined` was no longer used and has been removed.
+
 
 
 ## 0.9.8

diff --git a/Sources/RichTextKit/Colors/ColorRepresentable.swift b/Sources/RichTextKit/Colors/ColorRepresentable.swift
@@ -3,7 +3,7 @@
 //  RichTextKit
 //
 //  Created by Daniel Saidi on 2022-05-28.
-//  Copyright © 2022-2023 Daniel Saidi. All rights reserved.
+//  Copyright © 2022-2024 Daniel Saidi. All rights reserved.
 //
 
 #if macOS

diff --git a/Sources/RichTextKit/Colors/RichTextColor+Picker.swift b/Sources/RichTextKit/Colors/RichTextColor+Picker.swift
@@ -25,13 +25,13 @@ public extension RichTextColor {
          Create a rich text color picker that binds to a color.
 
          - Parameters:
-          - type: The type of color to pick, by default `.undefined`.
+          - type: The type of color to pick.
           - icon: The icon to show, if any, by default the `type` icon.
           - value: The value to bind to.
           - quickColors: Colors to show in the trailing list, by default no colors.
          */
         public init(
-            type: RichTextColor = .undefined,
+            type: RichTextColor,
             icon: Image? = nil,
             value: Binding<Color>,
             quickColors: [Color] = []

diff --git a/Sources/RichTextKit/Colors/RichTextColor.swift b/Sources/RichTextKit/Colors/RichTextColor.swift
@@ -3,7 +3,7 @@
 //  RichTextKit
 //
 //  Created by Daniel Saidi on 2022-05-28.
-//  Copyright © 2022-2023 Daniel Saidi. All rights reserved.
+//  Copyright © 2022-2024 Daniel Saidi. All rights reserved.
 //
 
 import SwiftUI
@@ -29,21 +29,13 @@ public enum RichTextColor: String, CaseIterable, Codable, Equatable, Identifiabl
 
     /// Underline color.
     case underline
-
-    /// An undefined color type.
-    case undefined
 }
 
 public extension RichTextColor {
 
     /// The unique color ID.
     var id: String { rawValue }
 
-    /// All relevant cases.
-    static var allCases: [RichTextColor] {
-        [.foreground, .background, .strikethrough, .stroke, .underline]
-    }
-
     /// The corresponding rich text attribute, if any.
     var attribute: NSAttributedString.Key? {
         switch self {
@@ -52,7 +44,6 @@ public extension RichTextColor {
         case .strikethrough: .strikethroughColor
         case .stroke: .strokeColor
         case .underline: .underlineColor
-        case .undefined: nil
         }
     }
 
@@ -64,7 +55,6 @@ public extension RichTextColor {
         case .strikethrough: .richTextColorStrikethrough
         case .stroke: .richTextColorStroke
         case .underline: .richTextColorUnderline
-        case .undefined: .richTextColorUndefined
         }
     }
 
@@ -76,7 +66,6 @@ public extension RichTextColor {
         case .strikethrough: .strikethroughColor
         case .stroke: .strokeColor
         case .underline: .underlineColor
-        case .undefined: .strokeColor
         }
     }
 

diff --git a/Sources/RichTextKit/Context/RichTextContext+Colors.swift b/Sources/RichTextKit/Context/RichTextContext+Colors.swift
@@ -26,7 +26,6 @@ public extension RichTextContext {
         case .strikethrough: strikethroughColor
         case .stroke: strokeColor
         case .underline: underlineColor
-        case .undefined: nil
         }
     }
 
@@ -44,7 +43,6 @@ public extension RichTextContext {
         case .strikethrough: strikethroughColor = val
         case .stroke: strokeColor = val
         case .underline: underlineColor = val
-        case .undefined: return
         }
     }
 }
diff --git a/Sources/RichTextKit/_Deprecated/RichTextColorPicker+Deprecated.swift b/Sources/RichTextKit/_Deprecated/RichTextColorPicker+Deprecated.swift
@@ -14,6 +14,7 @@ public extension RichTextColor.Picker {
         quickColors: [Color] = []
     ) {
         self.init(
+            type: .foreground,
             icon: showIcon ? color.icon : nil,
             value: value,
             quickColors: quickColors