-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Minor UI tweaks #128
Conversation
Sources/RichTextKit/_Deprecated/RichTextAlignment+Deprecated.swift
Outdated
Show resolved
Hide resolved
Now this doesnt work on macOS, investigating why... Will fix this later, got a bigger fish to catch. |
It's so strange that the toggle buttons work great in dark mode on macOS, but not in iOS. I'll check if I can get it to work with the current approach before we merge this. |
Sources/RichTextKit/_Deprecated/RichTextAlignment+Deprecated.swift
Outdated
Show resolved
Hide resolved
Thank you for finding all these strange glitches. My idea was for a developer to be able to set |
Is this ready to merge? |
I will refactor this a bit (no duplicate static |
Sources/RichTextKit/Component/RichTextViewComponent+Attributes.swift
Outdated
Show resolved
Hide resolved
I spent enormous time trying to hack |
Hey @DominikBucher12 - I looked at the many things you had to do to make this work and realized that many of the views were sooo bloated, with view modifiers and styles that made it hard to affect the entire look of, say, a format sidebar. I therefore removed a LOT of code and styles from the various views, so that you can now use foreground color, tint, accent color etc. on an entire view hierarchy and affect all toggles within. I also noticed that the When I did, I noticed that the I've also removed the color picker color adjustment, since it made it impossible to e.c. pick a black background color in dark mode. Instead, I've added a reset button to the quick colors, which applies I have also deprecated a bunch of styles, and moved many views into namespaces. Let's go through this PR together and see which parts we still want to add to |
5f9f2c3
to
d399348
Compare
Looks like this tweaking SFSymbol/TintColor journey is finally over, ready to merge. |
What this PR do:
How to test it
Related: #125
How it looks now: