[BUGFIX Fix Alignment setting #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikBucher12
commented
Jan 24, 2024
|
Also currently on macOS since no configuration with default font is set yet. |
DominikBucher12
commented
Jan 24, 2024
| // The cursor is at the beginning of the text | ||
| if range.location == 0 { | ||
| return setAlignment(alignment, atIndex: 0) | ||
| } | ||
|
|
||
| // The cursor is immediately after a newline | ||
| if let char = text.character(at: range.location - 1), char.isNewLineSeparator { | ||
| return setAlignment(alignment, atIndex: range.location) | ||
| // We dont want to set attributed string to previous line, | ||
| // isNewLineSeparator is unfortunately omitted by API. |
There was a problem hiding this comment.
@danielsaidi this was main reason the line above were being aligned as well as the current line.
|
Great job! Merging this to give it a go. 😀 |
|
@DominikBucher12 This doesn't work for me, see movie. The same problem on both macOS and iOS. |
Skarminspelning.2024-01-24.kl.23.08.03.mov |
|
If you want to continue to look at this, I merged it to |
|
@DominikBucher12 Actually, if I just have this in public extension RichTextViewComponent {
/// Get the rich text alignment at current range.
var richTextAlignment: RichTextAlignment? {
guard let style = richTextParagraphStyle else { return nil }
return RichTextAlignment(style.alignment)
}
/// Set the rich text alignment at current range.
///
/// > Todo: Something's currently off with alignment. It
/// spils over to other paragraphs when moving the input
/// cursor and inserting new text.
func setRichTextAlignment(
_ alignment: RichTextAlignment
) {
if richTextAlignment == alignment { return }
setRichTextAlignment(alignment, at: selectedRange)
}
} |
|
I have pushed a MUCH shorter version of the alignment setter to the new branch. It seems to work pretty well, but please check it out too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do:
How to test it
Where you can start
alignment.mov