Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the vertical scrollbar when the editor's config isScrollingEnabl… #199

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

travisbikkle
Copy link
Contributor

This pr fix #198 .
It's been tested like I wrote in the issue.
I left this pr here so it can be merged anytime when the issue/feature is approved.

@travisbikkle
Copy link
Contributor Author

Feel free to close this pr if the feature is declined or the code is bad.

@danielsaidi
Copy link
Owner

Hi @travisbikkle

Thank you so much! I will take a look 🙌

@danielsaidi
Copy link
Owner

This is perfect, thank you! I will add a separate property to the configuration, to let you hide the scrollbar while still having scrolling enabled.

@danielsaidi danielsaidi merged commit ceee5fe into danielsaidi:main Oct 8, 2024
1 check passed
@danielsaidi danielsaidi added this to the 1.1 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE DISCUSSION] Should we hide the vertical scroller when isScrollingEnabled is false?
2 participants