Fix #13537 FP passedByValue for template type (#7195)

The same logic also exists in `setArrayDimensionsUsingValueFlow()` (not changed yet).
danmar · Jan 12, 2025 · 46781df · 46781df
1 parent 93fd884
commit 46781df
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/symboldatabase.cpp b/lib/symboldatabase.cpp
@@ -3731,7 +3731,8 @@ bool Variable::arrayDimensions(const Settings& settings, bool& isContainer)
             // TODO: only perform when ValueFlow is enabled
             // TODO: collect timing information for this call?
             ValueFlow::valueFlowConstantFoldAST(const_cast<Token *>(dimension_.tok), settings);
-            if (dimension_.tok && dimension_.tok->hasKnownIntValue()) {
+            if (dimension_.tok && (dimension_.tok->hasKnownIntValue() ||
+                                   (dimension_.tok->isTemplateArg() && !dimension_.tok->values().empty()))) {
                 dimension_.num = dimension_.tok->getKnownIntValue();
                 dimension_.known = true;
             }

diff --git a/test/testother.cpp b/test/testother.cpp
@@ -11062,6 +11062,13 @@ class TestOther : public TestFixture {
               "    C(A<T> x_, B<T> y_) : x(x_), y(y_) {}\n"
               "};\n");
         ASSERT_EQUALS("", errout_str()); // don't crash
+
+        check("template <typename T, int N>\n" // #13537
+              "    struct S {\n"
+              "    T a[N];\n"
+              "};\n"
+              "void f(S<char, 3> s) {}\n");
+        ASSERT_EQUALS("", errout_str());
     }
 
     void checkComparisonFunctionIsAlwaysTrueOrFalse() {