Skip to content

Commit

Permalink
updated clang-tidy.md
Browse files Browse the repository at this point in the history
  • Loading branch information
firewave committed May 24, 2024
1 parent 920478f commit b8ace14
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions clang-tidy.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ These are coding guidelines we do not follow. Some of the checks might be explic
`readability-isolate-declaration`<br/>
`modernize-use-trailing-return-type`<br/>
`readability-uppercase-literal-suffix`<br/>
`readability-else-after-return`<br/>
`readability-identifier-length`<br/>

These do not reflect the style we are (currently) enforcing.
Expand Down Expand Up @@ -72,7 +71,7 @@ This leads to a mismatch of raw string literals and regular ones and does reduce

`-clang-analyzer-*`<br/>

Disabled because of false positives (needs to file an upstream bug report).
Disabled because of false positives (need to file upstream bug reports). The checks are also quite time consuming.

`misc-non-private-member-variables-in-classes`<br/>

Expand All @@ -82,7 +81,6 @@ We intentionally use this.

Leads to lots of "false positives". This seem to enforce a coding guidelines of certain codebases.


`bugprone-easily-swappable-parameters`<br/>

This produces a lot of noise and they are not fixable that easily.
Expand Down Expand Up @@ -121,7 +119,6 @@ We run this separately via `clang-include-cleaner` in the `iwyu.yml` workflow as
`misc-throw-by-value-catch-by-reference`<br/>
`readability-avoid-const-params-in-decls`<br/>
`bugprone-signed-char-misuse`<br/>
`readability-redundant-access-specifiers`<br/>
`concurrency-mt-unsafe`<br/>
`misc-use-anonymous-namespace`<br/>
`performance-avoid-endl`<br/>
Expand Down Expand Up @@ -186,7 +183,7 @@ We are not using SIMD instructions and it suggests to use `std::experiemental::`

It does not seem to produce any warnings for us (needs to be investigated) and it is one of the more expensive checks.

`misc-unused-using-decls`
`misc-unused-using-decls`<br/>

This is the most expensive check for several files and it is providing much in terms of code quality. Reported upstream as https://github.com/llvm/llvm-project/issues/72300.

Expand Down

0 comments on commit b8ace14

Please sign in to comment.