refs #12171 / fixed #12347 - improved handling of (unmatched) local and inline suppressions #5647
+374
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
force-pushed
the
test-suppr
branch
4 times, most recently
from
375689d to
8210435
Compare
This comment was marked as outdated.
This comment was marked as outdated.
firewave
force-pushed
the
test-suppr
branch
3 times, most recently
from
97c1254 to
f08f274
Compare
firewave
force-pushed
the
test-suppr
branch
2 times, most recently
from
9606dd6 to
825a8cb
Compare
firewave
changed the title
FileSettings
This comment was marked as outdated.
This comment was marked as outdated.
firewave
force-pushed
the
test-suppr
branch
4 times, most recently
from
d902cf6 to
edf3e71
Compare
firewave
commented
Apr 9, 2024
test/cli/inline-suppress_test.py
Outdated
|
|
||
|
|
||
| @pytest.mark.xfail(strict=True) | ||
| def test_unused_function_unmatched_build_dir_j_process(tmpdir): |
There was a problem hiding this comment.
This was already failing before my changes.
firewave
force-pushed
the
test-suppr
branch
4 times, most recently
from
01d932f to
f749f0a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
firewave
changed the title
firewave
force-pushed
the
test-suppr
branch
3 times, most recently
from
8e625a6 to
458341d
Compare
firewave
force-pushed
the
test-suppr
branch
2 times, most recently
from
c6f6339 to
3f2c505
Compare
firewave
commented
Jan 27, 2025
test/cli/other_test.py
Outdated
Comment on lines
2586
to
2588
| # TODO: the suppressions are generated outside of the scope which captures the analysis information | ||
| @pytest.mark.xfail(strict=True) | ||
| def test_inline_suppr_builddir_cached(tmp_path): |
There was a problem hiding this comment.
This regression is unfortunate but fixing this again requires some additional refactoring and this PR is already way too big...
firewave
commented
Jan 27, 2025
Comment on lines
+2601
to
2603
| # TODO: the suppressions are generated outside of the scope which captures the analysis information | ||
| @pytest.mark.xfail(strict=True) | ||
| def test_inline_suppr_builddir_j_cached(tmp_path): |
There was a problem hiding this comment.
This regression is unfortunate but fixing this again requires some additional refactoring and this PR is already way too big...
firewave
commented
Jan 27, 2025
Comment on lines
+129
to
+130
| # TODO: remove overrides when it is fully working | ||
| def __test_suppress_inline_project(tmp_path, extra_args): |
There was a problem hiding this comment.
I have no idea yet why this fails.
firewave
commented
Jan 27, 2025
test/cli/whole-program_test.py
Outdated
Comment on lines
159
to
160
| @pytest.mark.xfail(strict=True) | ||
| def test_suppress_inline_project_j(tmp_path): |
There was a problem hiding this comment.
I have no idea yet why this fails.
…nalysis has been run
|
I think this is fine to be merged. The regression are unfortunate but expected given the changes. But this has already taken way too long and there are lots of improvements compared to before. So this is an overall plus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.