This adds the rest of the emscripten macros that wrap javascript code… #6234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Half of the actions are not being run. Something's weird going on here. |
|
@firewave My changes do not seem related to the errors. Should I do something from my side? |
|
If you wish, you could add yourself to the AUTHORS file. That would trigger a rerun. |
|
@chrchr-github done |
|
There is now an error in coverage build due to 502 server error - Rebased to retrigger |
… to emscripten.cfg Namely: EM_ASM_DOUBLE EM_ASM_INT EM_ASM_PTR MAIN_THREAD_EM_ASM_DOUBLE MAIN_THREAD_EM_ASM_INT MAIN_THREAD_EM_ASM_PTR MAIN_THREAD_ASYNC_EM_ASM
That happens from time to time. We can just re-run that step when it happens. No need for a re-trigger. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to emscripten.cfg
Namely:
EM_ASM_DOUBLE
EM_ASM_INT
EM_ASM_PTR
MAIN_THREAD_EM_ASM_DOUBLE
MAIN_THREAD_EM_ASM_INT
MAIN_THREAD_EM_ASM_PTR
MAIN_THREAD_ASYNC_EM_ASM