Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed #13420 - Tokenizer did not contribute to --errorlist #7107

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

I did not add the debug warnings. I have not checked if we already include some of them in the output (we probably should but that can/should be addressed separately).

@firewave firewave marked this pull request as ready for review January 9, 2025 18:09
@danmar
Copy link
Owner

danmar commented Jan 11, 2025

I did not add the debug warnings. I have not checked if we already include some of them in the output (we probably should but that can/should be addressed separately).

I am skeptic about including the debug warnings. The debug warnings are stuff that normal users should not see.

But I am not sure exactly what this is used for. In the GUI the error list is used to show all possible ids in a list.. so the user can choose a suppression id in a list. And there the debug warnings would not be wanted. But well I guess the GUI could filter..

A welcome extension would be to add addon warnings to the --errorlist output also. But well I fear that could mean that we break lots of addons out there.

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@firewave
Copy link
Collaborator Author

A welcome extension would be to add addon warnings to the --errorlist output also. But well I fear that could mean that we break lots of addons out there.

That's why it should be optional: https://trac.cppcheck.net/ticket/13541.

@firewave firewave merged commit 11aef93 into danmar:main Jan 11, 2025
60 checks passed
@firewave firewave deleted the tokenize-errors branch January 11, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants