testrunner: cleaned up tests by using objects to pass the options #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
firewave
force-pushed
the
test-unused-opts
branch
from
7b77918 to
b171eda
Compare
firewave
changed the title
firewave
force-pushed
the
test-unused-opts
branch
2 times, most recently
from
f5d8fb0 to
3d91d31
Compare
firewave
commented
Jan 14, 2025
| @@ -652,24 +659,24 @@ class TestLeakAutoVar : public TestFixture { | |||
| check("void f(char* old, char* value, size_t len) {\n" | |||
| " char *str = strdup(value);\n" | |||
| " memcpy(old, str, len);\n" | |||
| "}\n", &s); | |||
| "}\n", dinit(CheckOptions, $.cpp = true, $.s = &s)); | |||
There was a problem hiding this comment.
This was never using the settings.
firewave
force-pushed
the
test-unused-opts
branch
from
3d91d31 to
24d5860
Compare
firewave
force-pushed
the
test-unused-opts
branch
from
24d5860 to
9cecba6
Compare
|
There were two more test cases which were passing the wrong parameters but I cannot find them anymore. I thought I had them in a different since I wanted to put those into a separate PR. There are also a few really big files I did not change yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.