-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #13550 Remove boostForeachError/checkboost.cpp #7198
Conversation
We should probably just simplify BOOST_FOREACH to a range-based loop and do away with checkboost.cpp (already exists in boost.cfg). |
If we really want to support MSVC's |
if (Token::simpleMatch(tok, "for each")) { | ||
// 'for each ( )' -> 'asm ( )' | ||
tok->str("asm"); | ||
// 'for each (x in y )' -> 'for (x : y)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's C++11 code. Does that work if we are using C++03 as standard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have any loop-handling code that is conditional on the standard. Also, the new simplification can only be an improvement on the asm
hack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely - especially since we are handling asm
so well. It also now matches what the library configurations are doing.
The test cases involving |
There are no instances of |
No description provided.