Fix #11393 FP danglingLifetime with pointer to pointer #7226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfultz2
reviewed
Jan 16, 2025
| @@ -648,6 +648,7 @@ void CheckAutoVariables::checkVarLifetimeScope(const Token * start, const Token | |||
| if (var && !var->isLocal() && !var->isArgument() && !(val.tokvalue && val.tokvalue->variable() && val.tokvalue->variable()->isStatic()) && | |||
| !isVariableChanged(nextTok, | |||
| tok->scope()->bodyEnd, | |||
| var->valueType() ? var->valueType()->pointer : 0, | |||
There was a problem hiding this comment.
As I recall the pointer value is different than the indirect value.
There was a problem hiding this comment.
Then how do we get the correct value here?
There was a problem hiding this comment.
Is the pointer a bitset that sets each level indirection? Or is that just const?
There was a problem hiding this comment.
///< 0=>not pointer, 1=>*, 2=>**, 3=>***, etc
constness and volatileness are bitsets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.