cleaned up some array length related code #7283
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/helpers.h
Outdated
| @@ -246,4 +246,6 @@ struct LibraryHelper | |||
| static Library::Error loadxmldoc(Library &lib, const tinyxml2::XMLDocument& doc); | |||
| }; | |||
|
|
|||
| #define ARRAY_LEN(x) sizeof(x) / sizeof(x[0]) | |||
There was a problem hiding this comment.
Can't we use std::size()?
There was a problem hiding this comment.
That is not available until C++17.
There was a problem hiding this comment.
Oh jeez. Time to update... to C++20.
| @@ -466,42 +466,42 @@ class TestCmdlineParser : public TestFixture { | |||
| void nooptions() { | |||
| REDIRECT; | |||
| const char * const argv[] = {"cppcheck"}; | |||
| ASSERT_EQUALS_ENUM(CmdLineParser::Result::Exit, parser->parseFromArgs(1, argv)); | |||
There was a problem hiding this comment.
Since this is used in so many tests, maybe there should be a template overload that deduces the size?
There was a problem hiding this comment.
Yes, using a helper which does that would be better.
firewave
force-pushed
the
array
branch
2 times, most recently
from
dfa20f1 to
e2f4223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.