Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for older rubies, rails and redis #566

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fatkodima
Copy link
Contributor

Also a candidate for a new major release, imo.

This PR drops support for:

  1. ruby < 3.1 (https://devcenter.heroku.com/articles/ruby-support-reference#supported-runtimes, https://endoflife.date/ruby)
  2. rails < 7
  3. redis < 6 (https://redis.io/docs/latest/operate/rs/installing-upgrading/product-lifecycle/).

It also updates CI to check against newer railses.

There is a mention about jruby in the readme, but no tests on CI. I would suggest just dropping it, as I am not sure many people (anyone?) uses it in production to worth the effort.

@fatkodima
Copy link
Contributor Author

fatkodima commented Nov 15, 2024

I also noticed, that there is a rubocop and standardrb. I would suggest removing the latter and properly use rubocop and fix all the current offenses.

Also, there is a

task "test:all": %i[rubocop test forked_tests benchmarks:memory benchmarks]
task, which runs forked_tests. These are not ran on CI currently and are broken. That should be also fixed.

I can help, if ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant