Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix: Correct Properties Passed to getResponseSender, Catch OpenAI Errors #1244

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

danny-avila
Copy link
Owner

Summary

This pull request addresses an issue where incorrect properties were being passed to the getResponseSender function. Additionally, it includes an enhancement to error handling, particularly for errors that occur at the start of generation. These changes aim to improve the robustness and reliability of the system.

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila merged commit e13b146 into main Nov 29, 2023
2 checks passed
@danny-avila danny-avila deleted the minor-fixes branch November 29, 2023 18:40
cnkang pushed a commit to cnkang/LibreChat that referenced this pull request Feb 6, 2024
…rrors (danny-avila#1244)

* fix: attempt to catch more errors, especially when generation started

* fix: pass the right properties to getResponseSender

* chore: Update .eslintrc.js and fix sendEmail.js linting errors
jinzishuai pushed a commit to aitok-ai/LibreChat that referenced this pull request May 20, 2024
…rrors (danny-avila#1244)

* fix: attempt to catch more errors, especially when generation started

* fix: pass the right properties to getResponseSender

* chore: Update .eslintrc.js and fix sendEmail.js linting errors
BertKiv pushed a commit to BertKiv/LibreChat that referenced this pull request Dec 10, 2024
…rrors (danny-avila#1244)

* fix: attempt to catch more errors, especially when generation started

* fix: pass the right properties to getResponseSender

* chore: Update .eslintrc.js and fix sendEmail.js linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant